Skip to content

Add some integration tests for the db panel#1739

Merged
charisk merged 2 commits intomainfrom
charisk/db-panel-integration-test
Nov 9, 2022
Merged

Add some integration tests for the db panel#1739
charisk merged 2 commits intomainfrom
charisk/db-panel-integration-test

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Nov 9, 2022

Adds some initial integration tests for the new db panel area.

Checklist

N/A - internal only.

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk added the secexp label Nov 9, 2022
@charisk charisk requested a review from a team as a code owner November 9, 2022 14:32
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This looks good to me 😻

I like the helper functions (e.g. checkOwnerItem) - makes the tests nice and easy to follow 😺

Copy link
Copy Markdown
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@charisk charisk enabled auto-merge (squash) November 9, 2022 15:14
@charisk charisk merged commit 47af1f8 into main Nov 9, 2022
@charisk charisk deleted the charisk/db-panel-integration-test branch November 9, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants